search

ambianic / fall-detection

Python ML library for people fall detection
Apache License 2.0
83 stars 16 forks source link

feat: add setup files #23

Closed bhavikapanara closed 2 years ago

commit-lint[bot] commented 3 years ago

Contributors

bhavikapanara

Commit-Lint commands
You can trigger Commit-Lint actions by commenting on this PR: - `@Commit-Lint merge patch` will merge dependabot PR on "patch" versions (X.X.Y - Y change) - `@Commit-Lint merge minor` will merge dependabot PR on "minor" versions (X.Y.Y - Y change) - `@Commit-Lint merge major` will merge dependabot PR on "major" versions (Y.Y.Y - Y change) - `@Commit-Lint merge disable` will desactivate merge dependabot PR - `@Commit-Lint review` will approve dependabot PR - `@Commit-Lint stop review` will stop approve dependabot PR
codecov[bot] commented 3 years ago

Codecov Report

Merging #23 (80234a7) into main (8a053b9) will increase coverage by 3.22%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   89.06%   92.29%   +3.22%     
==========================================
  Files          10       14       +4     
  Lines         869     1272     +403     
==========================================
+ Hits          774     1174     +400     
- Misses         95       98       +3
Impacted Files Coverage Δ
src/pipeline/pose_engine.py 65.65% <0.00%> (-23.41%) :arrow_down:
src/pipeline/inference.py 88.00% <0.00%> (-0.24%) :arrow_down:
fall_prediction.py 100.00% <0.00%> (ø)
tests/pipeline/test_fall_detect.py
src/pipeline/pose_base.py 91.83% <0.00%> (ø)
src/pipeline/movenet_model.py 97.05% <0.00%> (ø)
tests/pipeline/test_fall_detect_posenet.py 100.00% <0.00%> (ø)
tests/pipeline/test_fall_detect_movenet.py 100.00% <0.00%> (ø)
src/pipeline/posenet_model.py 100.00% <0.00%> (ø)
src/pipeline/fall_detect.py 98.62% <0.00%> (+10.09%) :arrow_up:
ivelin commented 3 years ago

@bhavikapanara you only added setup.cfg which is not enough to publish a package. You also need setup.py. See how we do this for peerjs-python.

ivelin commented 3 years ago

Look closer at the peerjs-python CI scripts for packaging and publishing a pypi package.

The three key scripts you need to study and understand are:

  1. https://github.com/ambianic/peerjs-python/blob/master/.github/workflows/pythonpackage.yml
  2. https://github.com/ambianic/peerjs-python/blob/master/build/prepare-release.sh
  3. https://github.com/ambianic/peerjs-python/blob/master/.github/workflows/pythonpublish.yml

pythonpackage.yml uses semantic release to analyze commits, prepare changelog and decide how to version the next release. prepare-release.sh creates a local python package pythonpublish.yml pushes the local package to the pypi package repo.

While testing your local scripts and CI runs, make sure to use TestPyPi to publish your new package from the CI workflow instead of the official PyPi repo.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: