ambianic / peerjs-python

Python port of PeerJS client
Apache License 2.0
89 stars 33 forks source link

Move ICE server config outside of python code to a config file #34

Closed ivelin closed 4 years ago

ivelin commented 4 years ago

Currently ICE server config resides in util.py

It would be more convenient for users to edit ICE settings if they are in a separate and documented config file, e.g. webrtc-config.yaml

This is the section that can be moved:

RTCConfiguration(
    iceServers=[
        RTCIceServer(
            urls=[
                "stun:stun1.l.google.com:19302",
                "stun:stun2.l.google.com:19302",
                "stun:stun3.l.google.com:19302",
                "stun:stun4.l.google.com:19302",
                "stun:stun.l.google.com:19302",
                "stun:stun.services.mozilla.com:3478",
                "stun:stunserver.org:3478",
                ]
                ),
        RTCIceServer(
            urls=['turn:numb.viagenie.ca'],
            username='webrtc@live.com',
            credential='muazkh'
            ),
        RTCIceServer(
            urls=['turn:192.158.29.39:3478?transport=udp'],
            credential='JZEOEt2V3Qb0y27GRntt2u2PAYA=',
            username='28224511:1379330808'
            ),
        RTCIceServer(
            urls=['turn:192.158.29.39:3478?transport=tcp'],
            credential='JZEOEt2V3Qb0y27GRntt2u2PAYA=',
            username='28224511:1379330808'
            ),
        RTCIceServer(
            urls=['turn:turn.bistri.com:80'],
            credential='homeo',
            username='homeo'
            ),
        RTCIceServer(
            urls=['turn:turn.anyfirewall.com:443?transport=tcp'],
            credential='webrtc',
            username='webrtc'
            ),
        RTCIceServer(
            urls=["turn:0.peerjs.com:3478"],
            username="peerjs",
            credential="peerjsp"
            )
        ]
    )
ivelin commented 4 years ago

:tada: This issue has been resolved in version 1.4.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: