ambiata / atmosphere-python-sdk

Python sdk to create custom code interacting with Atmosphere
MIT License
0 stars 0 forks source link

Fix for the version still failing #12

Closed jamylak closed 3 years ago

jamylak commented 3 years ago

https://github.com/ambiata/iag-total-loss-au/pull/13/checks?check_run_id=1949186694

#16 1.719   Cloning https://github.com/ambiata/atmosphere-python-sdk (to revision v0.3.0) to /tmp/pip-req-build-63m0wjjf
#16 3.278     ERROR: Command errored out with exit status 1:
#16 3.278      command: /usr/local/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-req-build-63m0wjjf/setup.py'"'"'; __file__='"'"'/tmp/pip-req-build-63m0wjjf/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-g1v1gglm
#16 3.278          cwd: /tmp/pip-req-build-63m0wjjf/
#16 3.278     Complete output (11 lines):
#16 3.278     Traceback (most recent call last):
#16 3.278       File "<string>", line 1, in <module>
#16 3.278       File "/tmp/pip-req-build-63m0wjjf/setup.py", line 2, in <module>
#16 3.278         from atmosphere._version import get_version
#16 3.278       File "/tmp/pip-req-build-63m0wjjf/atmosphere/__init__.py", line 1, in <module>
#16 3.278         from . import activity
#16 3.278       File "/tmp/pip-req-build-63m0wjjf/atmosphere/activity/__init__.py", line 1, in <module>
#16 3.278         from .base_class import BaseActivityCustomCode
#16 3.278       File "/tmp/pip-req-build-63m0wjjf/atmosphere/activity/base_class.py", line 4, in <module>
#16 3.278         from requests import Response
#16 3.278     ModuleNotFoundError: No module named 'requests'
#16 3.278     ----------------------------------------
#16 3.279 ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

It got a bit confused cause I tried to import atmosphere in the setup.py which then in turn tried to load modules eg. requests and caused an error on the build of sushi demo / total loss

I just duplicaated the get version (with a slight directory mod)

Please tell me if you have a better way but this works, just tested it