Closed kennedymwavu closed 8 months ago
Do you mind set_error
instead of set_error_handler
that would make it more consistent with other methods (e.g.: set_404
~set_404_handler
~).
Also maybe check that the handler
is indeed a function (there is an {assertthat} function for that somewhere in the package.
Very sensible. Making the suggested changes.
Don't merge yet... Let me make one more change: Use all()
instead of &&
for backward compatibility.
LGTM now.
Thanks!
Add a method to set the error handler
Closes #63