search

ambiot / ambd_matter

AmebaD public SDK to support Matter project
https://www.amebaiot.com/en/
10 stars 10 forks source link

[tools] fix number of DAC generated by gen-certs-enhanced.sh #128

Open ZivLow opened 2 months ago

ZivLow commented 2 months ago

This PR fixes an issue with gen-certs-enhanced.sh not generating DAC when requesting for 1 DAC

Setup

cd tools/matter/factorydata
sudo chmod u+x gen-certs-enhanced.sh

Before fix

Run gen-certs-enhanced.sh

./gen-certs-enhanced.sh ~/dev/connectedhomeip ~/dev/connectedhomeip/out/host/chip-cert 1 2
Is PAI vid-scoped (y/n)? n
How many DAC do you want to generate? 1

No DAC generated

ls myattestation | grep DAC

After applying fix (changing comparison operator to <=) on gen-certs-enhanced.sh

Remove previously generated myattestation

rm -rf myattestation

Re-run gen-certs-enhanced.sh

./gen-certs-enhanced.sh ~/dev/connectedhomeip ~/dev/connectedhomeip/out/host/chip-cert 1 2
Is PAI vid-scoped (y/n)? n
How many DAC do you want to generate? 1

DAC is generated

$ ls myattestation | grep DAC
Chip-Test-DAC-1-2-Cert-1.der
Chip-Test-DAC-1-2-Cert-1.pem
Chip-Test-DAC-1-2-Key-1.der
Chip-Test-DAC-1-2-Key-1.pem