search

ambisonictoolkit / atk-reaper

Ambisonic Toolkit as a set of JSFX plugins for the REAPER DAW.
Other
74 stars 10 forks source link

Small bug in ATK FOA Decoder Psycoshelf #75

Closed gsenna closed 2 years ago

gsenna commented 3 years ago

Hi,

Should line 94 of the ATK FOA Decoder Psycoshelf read as

wc = tan($PI * mFreq * inverseSamplesblock);

instead of

wc = tan(pi * mFreq * inverseSamplesblock);

?

Thanks!

joslloand commented 3 years ago

@lossius, the line in question: https://github.com/ambisonictoolkit/atk-reaper/blob/master/plugins/FOA/Decode/PsychoShelf#L94

joslloand commented 3 years ago

compare with: https://github.com/ambisonictoolkit/atk-reaper/blob/master/plugins/FOA/Transform/NearfieldProximity#L126

gsenna commented 3 years ago

Hi,

Thanks for the quick reply. Another issue seems to be that the filter becomes unstable depending on the samplesblock used. 128 works, but with values like 256 and 512 the amplitude blows up.

lossius commented 2 years ago

I set up a new issue #78 to address the instability, and close this one.