ambisonictoolkit / atk-reaper

Ambisonic Toolkit as a set of JSFX plugins for the REAPER DAW.
Other
74 stars 10 forks source link

JSFX decoders - typos in number specifications #77

Closed joslloand closed 2 years ago

joslloand commented 2 years ago

Hello,

We are in the process of making JSFX a little more strict in terms of how numbers are specified. Can you apply this very minor change to your awesome plug-ins? Thanks!

Justin

diff --git a/plugins/FOA/Decode/Pantophonic2D b/plugins/FOA/Decode/Pantophonic2D index f8015e1..008873c 100644 --- a/plugins/FOA/Decode/Pantophonic2D +++ b/plugins/FOA/Decode/Pantophonic2D @@ -122,7 +122,7 @@ function calculateLedCoordinates() local(i, j, lAngleLo, lAngleMid, lAngleHi, lA // Angles in degrees lAngleInc = 360./mNumSpeakers; lAngleLo = 90. - 0.5mSpeakerLayoutlAngleInc + 0.5*mAngularDistance;

  • lAngleMid = 90. + (0.5. - (0.5mSpeakerLayout))lAngleInc;
  • lAngleMid = 90. + (0.5 - (0.5mSpeakerLayout))lAngleInc; lAngleHi = 90. + (1.0 - (0.5mSpeakerLayout))lAngleInc - 0.5*mAngularDistance;

    // Converted to radians

diff --git a/plugins/FOA/Decode/Periphonic3D b/plugins/FOA/Decode/Periphonic3D index 7292f84..b4cd2f1 100644 --- a/plugins/FOA/Decode/Periphonic3D +++ b/plugins/FOA/Decode/Periphonic3D @@ -140,7 +140,7 @@ function calculateLedCoordinates() local(i, j, lAngleLo, lAngleMid, lAngleHi, lA // Angles in degrees lAngleInc = 360./mNumSpeakerPairs; lAngleLo = 90. - 0.5mSpeakerLayoutlAngleInc + 0.5*mAngularDistance;

  • lAngleMid = 90. + (0.5. - (0.5mSpeakerLayout))lAngleInc;
  • lAngleMid = 90. + (0.5 - (0.5mSpeakerLayout))lAngleInc; lAngleHi = 90. + (1.0 - (0.5mSpeakerLayout))lAngleInc - 0.5*mAngularDistance;

    // Converted to radians

joslloand commented 2 years ago

Q: do we need to check other scripts, @lossius?