Closed swans-one closed 10 years ago
@wesleykendall This build is failing, and it looks like it's because of something in django-entity. It runs fine locally, but when run on travis it spits out this error:
error: /home/travis/build/Wilduck/django-entity-emailer/django_entity-0.3.5-py2.7.egg/entity/migrations: Not a directory
It seems that django-entity is missing a "migrations" directory? Any thoughts?
@wesleykendall @jmcriffey Comments addressed. Thanks for looking over this.
Looks good to me. :guitar:
@Wilduck had one comment about a query you were doing
@Wilduck you may want to use ENTITY_EMAILER_DEFAULT_FROM as the setting variable instead. I bet many people use a DEFAULT_FROM_EMAIL variable for other things
@wesleykendall I implemented your performance optimization, and also created the option for a user to set settings.ENTITY_EMAILER_FROM_EMAIL
. If that value is set, it will be sent in the from field, otherwise the DEFAULT_FROM_EMAIL
will be used.
@Wilduck you left a print statement in there. ready to merge when its gone
@wesleykendall @jmcriffey This pull request implements the feature of having an email sent immediately upon saving it to the database. It implements this through a post-save hook, and spawns a celery task to actually send the email.
Of all the code in this pull request, I'm most interested in hearing feedback on the following:
tasks.SendEmailAsyncNow.run
look sensible? This is the piece that actually sends the email out.settings.DEFAULT_FROM_EMAIL
. Is that reasonable?