ambitioninc / django-entity-emailer

:mailbox: Send email to Entities.
MIT License
8 stars 8 forks source link

Django4 compatibility and some legacy cleanup #91

Closed geophphrie closed 1 year ago

geophphrie commented 1 year ago

The only thing remaining here to resolve is the usage of ambition-django-uuidfield. Not sure the plan for that.

somewes commented 1 year ago

it looks like this depends on ambition-django-uuidfield, which hasn't been kept up to date in our spreadsheet. i'd like to see if we can get rid of our custom uuid field package and do something like we did with the timezone field. rather than maintaining a whole package to make a small change, we can just extend the field class in ambition-utils to add any extra logic there. i don't know what custom functionality is needed there if any.

geophphrie commented 1 year ago

That sounds good @somewes . At the very moment I'm doing a search-and-destroy purely on hard incompatibilities with Django 4. I.e. I have upgraded a local system to Dj4 and am seeing what breaks just trying to do a python manage.py check Some of these fixes are pretty low hanging fruit. If I get them out of the way it will be easier to see what other work might need to be done. But stuff like uuidfield and timezone will be great to abstract out in a better way and fix across the board.

somewes commented 1 year ago

removed the uuid field dependency since it is built into django and was switched in 2017