search

ambitus / pyracf

Python interface to the RACF Command interface.
https://ambitus.github.io/pyracf/
Apache License 2.0
10 stars 4 forks source link

Update pyproject.toml #8

Closed ElijahSwiftIBM closed 1 year ago

ElijahSwiftIBM commented 1 year ago

change setup.cfg and setup.py to pyproject.toml

pyproject.toml can still work with a minimal setup.py for dynamic elements like the pyobject we are building, but the pyproject toml is useful

Update pyproject.toml

:bulb: Issue Reference

Issue: #3

:computer: What does this address?

Standards are shifting from setup.py to pyproject.toml for static attributes

:pager: Implementation Details

Most items from the setup.py and setup.cfg are moved to pyproject.toml with the exception of dynamic extensions which are still built as part of setup.py

:clipboard: Is there a test case?

Test case suite does not test build, but code was built from pip install through the repo using ssh and a manually built wheel and functionality is still present.

Either include the path to the test case file, or details on a manual test

lcarcaramo commented 1 year ago

Linters, code formatters, and other development dependencies don't appear to pulling configuration from pyproject.toml.

lcarcaramo commented 1 year ago

It also looks like an update or two might need to be made to CONTRIBUTING.md where references to setup.py should probably be changed to pyproject.toml.

ElijahSwiftIBM commented 1 year ago

It also looks like an update or two might need to be made to CONTRIBUTING.md where references to setup.py should probably be changed to pyproject.toml.

Only identified one reference. Changed to: * Make any necessary updates topyproject.toml.

ElijahSwiftIBM commented 1 year ago

Linters, code formatters, and other development dependencies don't appear to pulling configuration from pyproject.toml.

to my knowledge, pylint and isort are getting their config correctly. flake8 does not support pyproject.toml. I have added a .flake8 file containing the following for now. This can be changed to a setup.cfg if preferred.

[flake8]
    ignore = W503,E122,E203
    max-line-length = 99
    per-file-ignores = __init__.py:F401