amboltio / emily-cli

Emily-CLI -> Combine the power of Python and Docker
15 stars 1 forks source link

Emily incorrectly reporting missing VSCode (insiders) #14

Open zeyus opened 2 years ago

zeyus commented 2 years ago

Describe the bug

emily build and emily doctor report Visual Studio Code and it's extensions as missing, and there's no documentation on how to specify the path to the binary.

I have VSCode Insiders build, which has a different binary name (Code - Insiders.exe) and script (code-insiders.cmd).

To Reproduce Steps to reproduce the behavior:

  1. Using Emily command 'emily build'
  2. Entered value: none
  3. See error
Found 3 essential issue(s). Some requirements might require
       the terminal to be restarted before they are detected
       correctly

Expected behavior

Emily detects vscode insiders builds or allows the configuration of the vscode binary path.

Add logs

Log is empty. No .emily folder.

Screenshots

image

Desktop (please complete the following information):

Additional context

If I create a copy of the script and call it code.cmd then it successfully detects VSCode.

image

image

SimonLinnebjergAmbolt commented 2 years ago

Hey @zeyus. Thank you very much for submitting this issue and for the detailed description. We are happy that you figured out how to make it work with vscode insiders, and that you included your solution in the description. We will consider integrating vscode insiders with Emily. What we will do for now, is to include your solution in our documentation for other users that wants to use VScode insiders.

zeyus commented 2 years ago

@SimonLinnebjergAmbolt great, no problems, just wanted to flag it in case someone else ran into the same issue :) thanks!