[Intro to iOS] Submission of Assignment-1 "RottenTomatoes Client"

[ambrishverma]

"/cc @codepath" /cc @codepath

I have completed most of the required tasks for Assignment-1 (details in the Readme.txt).

https://github.com/ambrishverma/iOS/tree/master/RottenTomatoes

Thanks Ambrish

[stepan]

Hey Ambrish,

Your README is not complete: it doesn't have number of hours spent, and the walkthrough gif. You can copy from the example. Also, you are missing required stories. Please complete them as soon as possible.

[ambrishverma]

Hi Stephen,

Thank you for your feedback and my apologies for missing out a few details in the Readme.txt.

I have updated the Readme file with time spent and gif information, though walkthrough gif I had already uploaded in the same submission folder on Github. https://github.com/ambrishverma/iOS/blob/master/RottenTomatoes/Ambrish-RottenTomatoes-Demo.gif https://github.com/ambrishverma/iOS/blob/master/RottenTomatoes/Ambrish-RottenTomatoes-Demo.gif

I am still working on finishing up remaining required stories and will wrap them up likely by tonight.

Thanks Ambrish

On Feb 9, 2015, at 12:18 PM, Stepan Grigoryan notifications@github.com wrote:

Hey Ambrish,

Your README is not complete: it doesn't have number of hours spent, and the walkthrough gif. You can copy from the example http://courses.codepath.com/courses/intro_to_ios/pages/rotten_tomatoes_readme. Also, you are missing required stories. Please complete them as soon as possible.

— Reply to this email directly or view it on GitHub https://github.com/ambrishverma/iOS/issues/1#issuecomment-73582001.

[ambrishverma]

[codepathreview]

:+1: nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. For each point in the homework feedback checklist, I'll either confirm that you're on the right track with the implementation, or I'll provide some feedback:

• Be sure to follow the Swift code styling conventions for the homework. Here are a few useful guides:
  • Ray Wenderlich Swift Style Guide
  • Github Swift Style Guide
• You should always try to minimize the number of properties and methods that are public or internal (access is internal by default). Make the access private if the property or function doesn't need to be accessed outside the class.
• In future homework, we will cover how to implement models that can deserialize from an NSDictionary. SwiftyJSON is a useful project for making it easier to deserialize the JSON response.
• Your custom Movie cell should have a property called movie. In the custom setter of movie, you should configure the various labels and images. This decouples your custom cells from the table view controllers.
• Your images are loading synchronously. This will block the UI thread and make it so that your app appears frozen while the images are being downloaded.
• Note that your images are stretched. You should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
• Your error message should be displayed if a network request fails and hidden again if it succeeds.

In general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.