search

ambrop72 / aprinter

3D printer firmware written in C++
Other
143 stars 42 forks source link

Fix compile problem with ConstantConfigManager #27

Closed johnkingsley closed 8 years ago

johnkingsley commented 8 years ago

The ConstantConfigManager doesn't have a clearApplyPending() method. I'm not sure if this is the "proper" way to fix this.

ambrop72 commented 8 years ago

Hi John Thanks for noticing this issue, I don't use the ConsantConfigManager often apparently.

As you might have suspected this is not the right way to fix it because RuntimeConfigManager may be used without a configuration-store feature (i.e. you can change settings at runtime but the firmware doesn't know how to save them permanently). Please add a stub implementation of clearApplyPending to ConstantConfigManager instead.

Note, the "apply pending" means that settings have been changed (in memory) but M930 (apply settings) has not been run yet. It's currently only used for the web interface to indicate this situation.

ambrop72 commented 8 years ago

Merged by cherry-pick, thanks.

johnkingsley commented 8 years ago

Thanks Ambroz. You're fast! :-) Sorry for the temporary mess in my git history and the need to cherry pick.