search

ambrosus / ambrosus-node-extended

Expanded reporting and organizational functionality for the Hermes node.
MIT License
5 stars 5 forks source link

Tests #48

Closed lazar-eric closed 5 years ago

conorseabrook commented 5 years ago

Are we creating/dropping a test specific database for these tests? If I ran this agains my local environment it should not delete my existing 'hermes' database. If so we should come up with a way to pass in the database name to the connection class.

conorseabrook commented 5 years ago

Overall it looks great.

One thing, can we rename the tests to account.service.spect.ts, account.controller.spect.ts, etc. I know it's redundant b/c of the file structure, but having multiple tests with the same file name ties us to that folder structure. I'd rather have unique file names, and if they are testing a certain area of the application we should try to mirror the application file name it is testing.