search

ambs / Config-AutoConf

Config::AutoConf Perl Module
Other
2 stars 7 forks source link

_get_extra_linker_flags: add library dirs #13

Closed salva closed 7 years ago

salva commented 7 years ago

The module provides method push_library_paths but then it ignores the given paths.

This patch changes _get_extra_linker_flags so that those extra directories are used.

rehsack commented 7 years ago

I understood the issue and looking forward to get my brain around the patch. To be true, it looks kind-of strange at the very first moment (but this might be much more issued by me than by the patch).

By the way - while I slap my brain around the patch - could you try to change the commit message in the way described in www.openembedded.org/wiki/Commit_Patch_Message_Guidelines ? While we don't do kernel hacking here, it's great having a summary, a reason & description and a clear "Signed Off" ;)

Cheers, Jens

salva commented 7 years ago

Hi,

I understood the issue and looking forward to get my brain around the patch. To be true, it looks kind-of strange at the very first moment (but this might be much more issued by me than by the patch).

By the way - while I slap my brain around the patch - could you try to change the commit message in the way described in www.openembedded.org/wiki/Commit_Patch_Message_Guidelines ? While we don't do kernel hacking here, it's great having a summary, a reason & description and a clear "Signed Off" ;)

I have updated the commit message and done a push --force.

rehsack commented 7 years ago

Commit has been cherry-picked and signed to let anyone aside of github notice

salva commented 7 years ago

thanks!