ambuda-org / vidyut

Infrastructure for Sanskrit software. For Python bindings, see `vidyut-py`.
49 stars 21 forks source link

Adding a उपसर्गः does not display properly #79

Closed vshylaja closed 11 months ago

vshylaja commented 11 months ago

https://ambuda-org.github.io/vidyullekha/?tab=dhatu&dhatu=01.0990&upasarga=n

I chose नि as उपसर्गः and the धातुः was षदॢँ विशरणगत्यवसादनेषु. Without the उपसर्गः the forms were displayed properly. However once I added the उपसर्गः it did not display the forms properly.

shreevatsa commented 11 months ago

I see the bug too. Interestingly, changing to "ni" in the url works correctly: https://ambuda-org.github.io/vidyullekha/?tab=dhatu&dhatu=01.0990&upasarga=ni

shreevatsa commented 11 months ago

I just sent https://github.com/ambuda-org/vidyut/commit/3bb5250cdaceea12380717cd174b7a0b59c2228f to fix this — should be fixed at the next push I imagine.

(Sorry Arun, I edited via the GitHub UI and I thought it would create a commit in a fork of the repo and send a PR, but looks like it committed to the repo directly… hope that's ok in this case!)

shreevatsa commented 11 months ago

(Ah it actually needs to be fixed here: https://github.com/ambuda-org/ambuda-org.github.io/blob/ab6b57b3e15ae01c9598ba18fb31e9e8a5fad8e5/vidyullekha/index.html#L163 — but will leave it to @akprasad do the update when he gets to it.)

akprasad commented 11 months ago

(Sorry Arun, I edited via the GitHub UI and I thought it would create a commit in a fork of the repo and send a PR, but looks like it committed to the repo directly… hope that's ok in this case!)

No problem! I try to keep a convention of prefixing commits in vidyut-prakriya with [prakriya] so I folded this change into my latest push.