amc-heme / scExploreR

Shiny app for single cell omics data visualization
https://amc-heme.github.io/scExploreR/
MIT License
2 stars 0 forks source link

Disable accept subset button while filters are being edited #265

Closed wish1832 closed 1 month ago

wish1832 commented 1 month ago

When editing subset filters, the "apply subset" button in the plots tab (or the "update" button in the dge tab) can be pressed before confirming or cancelling the filter. If the user presses this button, the filter being edited will not be applied, and the app can crash if the user then confirms the filter and runs the subset. The apply subset button should be disabled while filters are being edited.

Screenshot 2024-03-26 at 12 26 56 PM

srg0502 commented 1 month ago

the apply subset button is disabled

wish1832 commented 1 month ago

I confirmed that this has already disabled on the version in main. There may be a weird edge case where the "apply subset" button is not disabled while the edit window is open, though I haven't yet been able to find one. If one is found, we should re-open the issue with the specific edge case.