search

amcharts / amcharts3-angular2

Official Angular 2 plugin for amCharts V3
99 stars 35 forks source link

Readme missing data #44

Open jimmykane opened 7 years ago

jimmykane commented 7 years ago

Hi there the readme is not so well done.

Instead of putting the script tags to point at node_modules (which will not avaialble online) you can edit your CLI for angular:

scripts": [
        "../node_modules/jquery/dist/jquery.js",
        "../node_modules/tether/dist/js/tether.js",
        "../node_modules/bootstrap/dist/js/bootstrap.js",
        "../node_modules/amcharts3/amcharts/amcharts.js",
        "../node_modules/amcharts3/amcharts/serial.js",
        "../node_modules/amcharts3/amcharts/themes/light.js",
      ],

Also I was missing some images so you need to: 

"assets": [
        "assets",
        "favicon.ico",
        {
          "glob": "**/*",
          "input": "../node_modules/amcharts3/amcharts/images/",
          "output": "./amcharts/images"
        }
      ],
Pauan commented 7 years ago

The README does not assume that you are using angular-cli, so it uses the AmCharts CDN.

You are right that it might be a good idea to put in some directions specifically for angular-cli.