search

amcharts / amcharts3-react

Official amCharts V3 React component
Apache License 2.0
118 stars 50 forks source link

bunch of updates :) #30

Closed RahavLussato closed 4 years ago

RahavLussato commented 7 years ago

  1. change componentDidUpdate to componentWillReceiveProps : detection of changes need to happen before the chart will update to avoid multiple updates because the same changes. its more correct way by the best practices of react.

  2. add new prop chartVersion: in my case i have situations that i making math calc on all the data and change all the data, in this cases i don't want to waste time to go all over the data, i want to clear all the and make a new chart (its much faster).

  3. add new prop activeSkip: in most of the cases when chart is get new data provider that bigger then the old one, the old data is not changed and i want to handle only the new indexes (again performance issue) so i added activeSkip prop to enable this, and new part that check if the new dataProvider is bigger than the old one and activeSkip is turned on it will handle only the part of the data that exists in the new dataProvider

  4. change this.state.chart.validateNow(); to this.state.chart.validateNow(true, false); it was doing errors inside amcharts.

iddan commented 7 years ago

Why isn't it merged? Is it tested?

RahavLussato commented 7 years ago

the comment is not valid anymore, i changed more stuff from the time i wrote that.

RahavLussato commented 7 years ago

its hard to contribute when its take long time to merge PR

Pauan commented 7 years ago

@RahavLussato I'm very sorry for the delay on this. I'll review this pull request now.