amcharts / amcharts3-react

Official amCharts V3 React component
Apache License 2.0
118 stars 50 forks source link

Should probably replace "devDependencies" in README.md #47

Closed apendua closed 7 years ago

apendua commented 7 years ago

This is alright for development environment,

{
  "devDependencies": {
    "react": "^15.4.2",
    "react-dom": "^15.4.2",
    "@amcharts/amcharts3-react": "^2.0.0"
  }
}

but ideally these should be dependencies as that's the place where most people expect to find packages that get bundled in the production version. Of course, in most cases it does not break anything, but I think it's still forth fixing to reduce confusion.

Pauan commented 7 years ago

@apendua I think it's the opposite: bundled dependencies should use devDependencies

If you have a library which uses dependencies, then anybody using that library will download those dependencies even though they're not used.

However, the script example doesn't do any bundling, so you're right that it should be using dependencies

Pauan commented 7 years ago

The script example has been updated to use dependencies