search

amcharts / amcharts3-react

Official amCharts V3 React component
Apache License 2.0
118 stars 50 forks source link

Pass `className` prop to container div #73

Closed brahma-dev closed 6 years ago

Pauan commented 6 years ago

Sorry for the delay, thanks for the pull request!

brahma-dev commented 6 years ago

@Pauan You seem to have removed the code that mattered.

Pauan commented 6 years ago

No, I did not. The master branch is for the old 1.x.x version, the 3.x.x branch is for the 3.x.x version.

The changes you made are in the 3.1.0 version, which is published to npm.

brahma-dev commented 6 years ago

Sorry. I'd been working on the wrong branch.

Pauan commented 6 years ago

No problem, it's a very confusing system: normally master is where pull requests should be sent to.

The reason we aren't doing that is because some of our users are using GitHub directly (not npm), so we didn't want to break their code, so we had to create a new branch.