search

amcharts / amcharts3-react

Official amCharts V3 React component
Apache License 2.0
118 stars 50 forks source link

Test cases failing: ReferenceError: AmCharts is not defined #88

Open vikramgupta1988 opened 5 years ago

vikramgupta1988 commented 5 years ago

While running testcases using Jest and Enzyme. I get an error like below.

ReferenceError: AmCharts is not defined at node_modules/@amcharts/amcharts3-react/amcharts3-react.js:253:3 at Object.<anonymous> (node_modules/@amcharts/amcharts3-react/amcharts3-react.js:298:3) at Object.<anonymous> (node_modules/@amcharts/amcharts3-react/index.js:6:3)

The AmCharts are imported in my project like below import AmCharts from '@amcharts/amcharts3-react'

I found a solution that is to be added to amcharts-react plugin at line 252. var AmCharts = AmCharts || {}; This is solving the issue. Can I create a PR for this?

Or alternatively can we ignore the import while running the test case?

darlesson commented 5 years ago

I would recommend the use of setupFiles to inject amCharts files to the environment.