search

amcharts / amcharts3

JavaScript Charts V3
Other
395 stars 129 forks source link

Images are hardcoded in amcharts.js without a version #86

Open TomDmitriev opened 7 years ago

TomDmitriev commented 7 years ago

I've noticed that the names of the images defined in amcharts.js, such as dragIconRoundBigH.svg have no version number. Why? I want all the images in my web app to be cacheable but in case of amcharts it seems it can't be done without processing amcharts.js, which is something I definetely don't want to do. I believe either the paths to the images should be defined in a css file so that they could be altered by an asset pipeline tool or if they're defined in amcharts.js, they should have a version number. In the former case the user such as myself would be responsible for versioning, in the latter case it would be the responsibility of the maintainers of amcharts.

ghost commented 7 years ago

So much support from devs, wow... How about you do not hardcode this stuff?

martynasma commented 7 years ago

How about checking docs first? Kaip ten yra, Šarūnai? ;)

http://docs.amcharts.com/3/javascriptcharts/ChartScrollbar#dragIcon

Tom, sorry this has been brought out, and for missing your original post altogether. We don't monitor GitHub issues as closely as our official support channels: helpdesk (contact@amcharts.com) and Facebook.