amcharts / amcharts5

The newest, fastest, and most advanced amCharts charting library for JavaScript and TypeScript apps.
Other
359 stars 96 forks source link

Drawing Index issue in the case of polyline #1376

Closed workingbuddy10 closed 8 months ago

workingbuddy10 commented 9 months ago

In the case of polyline I was facing the issue while deleting the drawing. Both user made drawing and unserialize drawings were deleting.

Steps to reproduce :

https://github.com/amcharts/amcharts5/assets/137867461/d0445b28-9eac-43dd-a1de-091cf525c3f8

But when I create polyline first then unsearilze the drawings, and then use the delete button it works fine.

Code pen to test : https://codepen.io/Ansh-m-the-reactor/pen/eYoNJNv

zeroin commented 9 months ago

I am afraid this is out of scope of free support.

workingbuddy10 commented 9 months ago

@zeroin this demo is been provided by @amcharts at #1365

I have only added the polyline data and now it is not working.

workingbuddy10 commented 9 months ago

https://github.com/amcharts/amcharts5/assets/137867461/2bfbe1de-f7d4-4c07-864c-ab89c61cbc3a

When we use eraser to erase the user drawn drawings then unseriliase drawings are also removing. @martynasma you can test this at the above given codepen link!!

martynasma commented 9 months ago

It looks like PolyLine tool does not add drawingId. We'll look into it.

workingbuddy10 commented 9 months ago

Thanks @martynasma for considering it!

martynasma commented 8 months ago

Fixed in 5.8.5.

[5.8.5] - 2024-03-15

Added

Fixed

Full change log.

Download options.

Make sure you clear your browser cache after upgrading. And feel free to contact us again if you are still experiencing this issue.

workingbuddy10 commented 8 months ago

Thanks for the quick upgrade @martynasma

But the polyline issue is still there. Case 1:

Case 2:

https://codepen.io/Ansh-m-the-reactor/pen/eYoNJNv

martynasma commented 8 months ago

It works fine for me in both cases. Did you clear your browser cache?

workingbuddy10 commented 8 months ago

Yes now it worked for me, I had only refreshed the app. Thanks @martynasma ! 💯