ForceDirectedTree with topDepth broken again

labriola commented 2 years ago

It appears in the last release, if you set a topDepth = 1 and do NOT provide an animation theme, you can lock up the browser

1) Just take your own example. open in codepen or jsfiddle. https://www.amcharts.com/demos/force-directed-tree/ 2) Add a topDepth: 1 to the creation of the force directed instance 3) Remove the animation theme. (root.setThemes([am5themes_Animated.new(root)]);

You will lock the browser in (what appears to be) a recursive loop

labriola commented 2 years ago

There may be more to this as well. I currently have my site locking up users in production because the configuration that worked previously now does a re-layout infinitely

martynasma commented 2 years ago

Thanks for the heads up! We'll need to fix it.

martynasma commented 2 years ago

Fixed in 5.1.5.

[5.1.5] - 2022-02-22

Added

minSize setting added to Flow (Chord and Sankey) series. It's a relative value to the sum of all values in the series. If set, this relative value will be used for small-value nodes when calculating their size. For example, if it's set to 0.01, small nodes will be sized like their value is 1% of the total sum of all values in series.

Changed

Direction of vertical panning with mouse wheel in an XYChart was inverted to make it consistent with OS native scrolling direction.

Fixed

Fixing ES6 module detection by BundlePhobia (Issue 294).
Parsing of dates using "i" format was not working properly when no milliseconds were supplied.
Using minZoomCount and maxZoomCount on a GaplessDateAxis was not working properly.
Sometimes vertical XYChart scrollbar was not reacting to chart's pan via mouse drag or wheel.
Using mouse wheel on a chart that was setup to pan was also zooming in/out in addition to pan.
In some cases grid on GaplessDateAxis was not being placed properly. Grid and Label placement improved.
ForceDirectedTree could freeze when used with Animated theme in some cases.
Changing of baseInterval on DateAxis was not properly working in some cases.
In some cases, when no animated theme was used, a state on a Sprite was not applied.
Setting data on MapSeries after geoJSON was updated was not working properly which resulted heat rules not to be applied.
It was difficult to make a selection close to the start/end of plot area on RadarChart.
When XYChart was fully zoomed in, using mouse wheel would start panning the chart instead of zoom.

Full change log.

Download options.

Make sure you clear your browser cache after upgrading. And feel free to contact us again if you are still experiencing this issue.

amcharts / amcharts5