amcharts / export

Apache License 2.0
56 stars 33 forks source link

Update Fabric.js to 1.6.2 #36

Closed NPC closed 8 years ago

NPC commented 8 years ago

Hi guys,

Latest version of Fabric.js is v1.6.2 (https://github.com/kangax/fabric.js/tree/master/dist), and it fixes some issues for creating canvas from SVG (for me transform: rotate() was completely wrong), so it may be good to update it in AmCharts/export too.

I just use it for converting some non-AmChart graphs for export, and it is convenient since I already have AmCharts on the page, so don't need to load it additionally.

maertz commented 8 years ago

Hi Anton, Thanks for pointing this out, we will verify this release and let you know when we've updated fabric.

NPC commented 8 years ago

I understand, you have to be careful with what they could break :) Thanks for looking into this!

maertz commented 8 years ago

Hi Anton,

We have verified that fabric version and were not able to find any issues. Please find the new version within the most recent commit https://github.com/amcharts/export/commit/dd2ffe872d906effd77fd2c2a9708bc5f2dea9f7.

Sincerely Benjamin

NPC commented 8 years ago

Thanks Benjamin!