Multiple issues in test suite

[dav1312]

https://github.com/amchess/ShashChess/blob/master/tests/HardPositions/HardPositions2022.epd The entire test suite needs to be revised, there are:

• Positions with multiple valid moves that are not in the bm field.
  • Example: Bh6 is also a best move https://github.com/amchess/ShashChess/blob/0aacc07681056ba9c902dd2558ac5735c8279e72/tests/HardPositions/HardPositions2022.epd#L31
  • Example: Ra8, Rc8, Re8, Rf8, Rh8 are all valid moves (TB7 draw) https://github.com/amchess/ShashChess/blob/0aacc07681056ba9c902dd2558ac5735c8279e72/tests/HardPositions/HardPositions2022.epd#L195
• Potentially wrong best moves?
  • Example: Qh6 seems to have a higher evaluation than Qg5 https://github.com/amchess/ShashChess/blob/0aacc07681056ba9c902dd2558ac5735c8279e72/tests/HardPositions/HardPositions2022.epd#L14
  • Example: Ne3 seems to have a higher evaluation than Rh3 https://github.com/amchess/ShashChess/blob/0aacc07681056ba9c902dd2558ac5735c8279e72/tests/HardPositions/HardPositions2022.epd#L136
  • Example: Ra1+ is not a draw https://github.com/amchess/ShashChess/blob/0aacc07681056ba9c902dd2558ac5735c8279e72/tests/HardPositions/HardPositions2022.epd#L233
• Wrong notations. Example: It should be Rxg7+ not Rg7 https://github.com/amchess/ShashChess/blob/0aacc07681056ba9c902dd2558ac5735c8279e72/tests/HardPositions/HardPositions2022.epd#L4
• Missing semicolon: https://github.com/amchess/ShashChess/blob/0aacc07681056ba9c902dd2558ac5735c8279e72/tests/HardPositions/HardPositions2022.epd#L108

[amchess]

Thanks. I will fix. Andrea

[amchess]

Are you sure Ra1+ isn't a draw?

[dav1312]

Are you sure Ra1+ isn't a draw?

Yes, I'm sure, its a forced mate

---

Note that the examples I mentioned are not all the positions that have issues in the test suite, they are just examples of that particular issue.