amclin / aem-packager

A node plugin that creates AEM packages installable through the Adobe Experience Manager package manager.
MIT License
16 stars 4 forks source link

fix: configurations not loading from package.json #487

Closed friendlymahi closed 1 year ago

friendlymahi commented 1 year ago

Fixes #486

Proposed Changes

Screenshots and Logs

Before

Last line from log : AEM package has been created and can be found in the current user's Maven package repository or in ./target

After

Last line from log : AEM package has been created and can be found in the current user's Maven package repository or in ./build-aem/package

Background context

...fill in details explaining why this is important or this approach should be used to solve the issue...

Where should the reviewer start / What requires special attention?

...specific files or actions...

How should this be manually tested?

  1. Create a new AEM project using react as frontend module type
  2. Include aem-packager in package.json dev dependencies and then use entries below for aem-packager section for ui.frontend module
  3. Update build script as react-scripts build && clientlib && aem-packager
  4. Execute the command npm i followed by npm build
  5. You shall see that package is created in target folder before this PR and will be the custom path mentioned in sample config section share in step2

Questions:

friendlymahi commented 1 year ago

@amclin - Requesting you to review this issue and PR, and if everything looks good, please merge the PR. Thanks !

friendlymahi commented 1 year ago

@amclin - hope you are doing well. can you please review this PR as I would like to use this package for our teams where aem or Java development is not required. If not feasible please let me know so I can copy over the code to our internal module and remove it once you merge the PR. Thanks

amclin commented 1 year ago

Thanks for the fix @friendlymahi !

amclin commented 1 year ago

:tada: This PR is included in version 3.1.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

friendlymahi commented 1 year ago

Thanks a lot for accepting the fix. Can you please review the other pr for new maven plug in version as the old one is or working as expected and not supported by Adobe any more.