Closed friendlymahi closed 1 year ago
@amclin - Requesting you to review this issue and PR, and if everything looks good, please merge the PR. Thanks !
@amclin - hope you are doing well. can you please review this PR as I would like to use this package for our teams where aem or Java development is not required. If not feasible please let me know so I can copy over the code to our internal module and remove it once you merge the PR. Thanks
Thanks for the fix @friendlymahi !
:tada: This PR is included in version 3.1.5 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Thanks a lot for accepting the fix. Can you please review the other pr for new maven plug in version as the old one is or working as expected and not supported by Adobe any more.
Fixes #486
Proposed Changes
getConfigsFromPackage
instead of passing the identifierScreenshots and Logs
Before
Last line from log : AEM package has been created and can be found in the current user's Maven package repository or in ./target
After
Last line from log : AEM package has been created and can be found in the current user's Maven package repository or in ./build-aem/package
Background context
...fill in details explaining why this is important or this approach should be used to solve the issue...
Where should the reviewer start / What requires special attention?
...specific files or actions...
How should this be manually tested?
aem-packager
in package.json dev dependencies and then use entries below foraem-packager
section for ui.frontend modulereact-scripts build && clientlib && aem-packager
npm i
followed bynpm build
Questions: