Fix bug Where timestamps! causes other Dolly::Document classes to have timestamps completes #108

amco / dolly

Not an ORM for CouchDB in rails.

8 stars 3 forks source link

Fix bug Where timestamps! causes other Dolly::Document classes to have timestamps completes #108 #109

Closed seancookr closed 8 years ago

netlogics commented 8 years ago

:shipit:

seancookr commented 8 years ago

maybe I should merge this to a 1.1 branch?

netlogics commented 8 years ago

Merging to 1.1 seems safest. Another option would be to separate concerns and use versioning.

revert the last commit f015b1d
update the version number to 1.0.1
merge this PR to 1.0
tag v1.0.1
submit a new PR with the reverted commit against the 1.0 branch
update the version number to 1.0.2
merge
tag as v1.1.0 or v1.0.2 depending.

Consequentially this would require consumers that only specify a branch name in their Gemfiles to use tags and or specify the version number.

seancookr commented 8 years ago

@javierg @neojin ☝️ what do you think regarding @netlogics suggestions? Trying to determine the proper course of action here so as not to break things

neojin commented 8 years ago

I'll defer to you guys as I don't know enough about your release process

javierg commented 8 years ago

I would merge it I'm 1.1 and start using semantic versioning after this

seancookr commented 8 years ago

Reopening this against 1.1