search

amcquade / fresh_script

Find Spotify tracks posted to the HipHopHeads subreddit and add them to a Spotify playlist.
MIT License
91 stars 61 forks source link

Fresh Script and Flask feature discussion #49

Closed amcquade closed 3 years ago

amcquade commented 5 years ago

I want to leave this issue open for anyone to make suggestions or comment on the new flask implementation of the project.

adamfitzgibbon commented 5 years ago

Looking at the app in browser, I think there's a couple places where we can use more of bootstrap to make the interface a little nicer. For example, if we use either the bootstrap grid or flexbox to align things with consistent margins, or perhaps combine the tracks accordion with bootstrap panels to clean that up a bit. That being said, I am be no means a UX designer so I understand just wanting to get something up and working. It looks pretty good for the most part!

adamfitzgibbon commented 5 years ago

One of these nights I'll try and open up a UI cleanup issue and link a PR with some of my ideas for utilizing bootstrap to do a bunch of css work for us.

dtcrout commented 5 years ago

Is there any reason why this project is limited to the hiphopheads subreddit? How about allowing the user to make a playlist based on their subreddit(s) of choice?

amcquade commented 5 years ago

@dtcrout there is no real reason for the limitation on the subreddit, thats just where i was interested in pulling tracks from. i have had thoughts about opening it up to the other subreddits, but the problem is a lot of the code is written specifically for hhh posts. eventually id like to see the flask component of the project to be more of a reddit music browser. i do like the idea of using multiple subreddits for a playlist.

slammer23 commented 5 years ago

Like the idea of this project. Didn’t clone and run the app yet. But got some feature ideas: a) allow the user to enter a sub and use the input to search b) alllow user on the tracks UI to select tracks and add to the playlist proactively. Currently the UI is used to display tracks only? c) extend playlist functionality to YouTube - query YouTube API and search for a music video of the track. This way you can listen to the song first. Or even create a YouTube playlist.

I could work on some of those ideas

amcquade commented 5 years ago

@slammer23 sound like good ideas! i think feature a) might take some serious refactoring, but would probably be worthwhile. in b), if by ui you mean the flask app, right now all it really does is grabs the first 25 hot posts in r/hhh and renders those that are tracks, so anythings fair game on that front. as for c) im not sure the best way to handle youtube links, open to any suggestions

serdar23 commented 5 years ago

I will propose a version for a), we see where to go from there. If that is ok for you. Short explanation below.

My idea is to create a input form with FlaskForm on the landing page (index.html). I would integrate that input field into a bootstrap navbar. This way it will be visible on all pages + a home link. Home nav-item will jump to the index page and cleans the form. After submitting the form with the search button, app jumps to the tracks function and re-uses the existing functionality. One change is to read the form value and search reddit based on that value.

serdar23 commented 5 years ago

Using the CodeHub app changed my screenname :)

amcquade commented 5 years ago

@serdar23 go for it! honestly down for anything, current implementation is shit lol. my only reservation is that we preserve as much original script code is as possible. the origin of this project was to be able to scrap /r/hhh, and i would like at least that much to stay the same.

NimishVerma commented 5 years ago

Is the work in flask branch still going on or done with already? I would like to contribute as well.

amcquade commented 5 years ago

@bigpythonimish yes! work is still on going, its just happening in the master branch. i think i created that when i first started putting flask into the project, now its gone stale, so just branch off the master if youd like to contribute!