search

amcquade / fresh_script

Find Spotify tracks posted to the HipHopHeads subreddit and add them to a Spotify playlist.
MIT License
91 stars 61 forks source link

Find a favicon for flask #51

Closed amcquade closed 3 years ago

amcquade commented 5 years ago

locate favicon from /r/hiphopheads, then well determine if we want to use that or create something else.

ghost commented 5 years ago

https://www.flaticon.com/free-icon/vintage-radio_1454014#term=boombox&page=1&position=8

Any idea why I couldn't get this to show? I had the file in the directory, name was right, and it was in the head tag

<link rel="shortcut icon" href="{{ url_for('static', filename='favicon.ico') }}">

I tried the other route as well

`import os from flask import send_from_directory

@app.route('/favicon.ico') def favicon(): return send_from_directory(os.path.join(app.root_path, 'static'), 'favicon.ico', mimetype='image/vnd.microsoft.icon')`

The project is really cool by the way, we just need suggestions for good hip-hop. Wise Intelligent, Mos Def, Nas

amcquade commented 5 years ago

@maxmarzolf simplest way to add the favicon would be to add it to the file templates/base.html so its included on every page. Thanks for the help!

ghost commented 5 years ago

And thank you for writing back, it was my first attempt at being constructive on open source, I'm super excited to get a response hahaha

rblcoder commented 5 years ago

@amcquade Can this issue be closed?

amcquade commented 5 years ago

@rblcoder PR is approved this issue will be closed.

rblcoder commented 5 years ago

favicon_io.zip Attached are all image files generated and downloaded along with the favicon https://favicon.io/favicon-generator/
Thank you, @amcquade

Chirag175 commented 4 years ago

I believe the solution that I've posted resolves the problem by adding a dynamic favicon and contains all the files that are necessary. @amcquade Will request the closure of this issue.

lemiesz commented 4 years ago

Is this issue still open looks like it was resolved?