amczuboka / Decagon-CondoManagementSystem

Condo Management System
3 stars 3 forks source link

added back-end for Add-New-Building-Operation #198

Closed PaulFarid closed 7 months ago

PaulFarid commented 7 months ago

68

added back-end for Add-New-Building-Operation

One cypress test fails but is fixed in Fixed my employees cypress test #199

PaulFarid commented 7 months ago

Tested with a new building 'vazzljgcg5f1712519549507'. Please change this console.log

      .addOperation(selectedBuildingId, operation)
      .then(() => {
        console.log('Operation added successfully!');
        this.operationForm.reset();
        this.submitted = false;
      })
      .catch((error) => {
        console.error('Error adding operation:', error);
      });

to this implementation

this.notification.sendNotification('Operation added successfully');

This is to make clear to the user that the operation was indeed added. Please also remove any commented code from your PR. Other than that, the implementation seems to work well.

fixed

PaulFarid commented 7 months ago

image

Please add an ID to the Operation interface.

i added it

sonarcloud[bot] commented 7 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint