amczuboka / Decagon-CondoManagementSystem

Condo Management System
3 stars 3 forks source link

#192 #193 Requests Follow-Up and Modifications #200

Closed Guillaume-Lachapelle closed 7 months ago

Guillaume-Lachapelle commented 7 months ago

Added request status for notifications

When the status is changed, the public user who made the request is notified.

Send requests to employee with that role instead of company

If no employee with that role is found, the notification is sent to the company.

Added and fixed tests

One cypress test fails but is fixed in Fixed my employees cypress test #199

closes #192 closes #193

Guillaume-Lachapelle commented 7 months ago

It's good. I like the feedback when the request status is updated Only thing is noticed is it sends the requests to every employee with the associated role, but should also only send it to employees assigned to that particular building

New code was just pushed to fix this issue ;)

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.6% Duplication on New Code

See analysis details on SonarCloud