Not sure I agree with adding comments `code written by AMD` throughout the code

amd / OpenCL-caffe

This is a Experimental version of OpenCL by AMD Research, we now recommend you to use The official BVLC Caffe OpenCL branch is over at Caffe branch now at https://github.com/BVLC/caffe/tree/opencl

Other

517 stars 152 forks source link

Not sure I agree with adding comments `code written by AMD` throughout the code #5

Closed hughperkins closed 9 years ago

hughperkins commented 9 years ago

Not sure I agree with adding comments code written by AMD throughout the code.

No-one else is doing this in caffe, as far as I can see? It is not standard practice in github projects, and it makes the code harder to read.

gujunli commented 9 years ago

This is added for the code review now. We will discuss whether to remove it later. Thanks for pointing it out. I guess a lot of people might feel the same with you.

hughperkins commented 9 years ago

Showing changes is one of the purposes of git. By the way, I recommend, to make the code review easier, doing:

create a new branch caffe-master, that points to commit ad8d129
create a pull request, from dev onto caffe-master

=> we can then easily see the changes, and easily comment on them