search

amdonov / lite-idp

Lightweight SAML Identity Provider
Apache License 2.0
210 stars 48 forks source link

SAMLv2 timestamps must be in UTC: #15

Closed colin-campbell closed 5 years ago

colin-campbell commented 5 years ago

Standard here: http://docs.oasis-open.org/security/saml/v2.0/saml-core-2.0-os.pdf #1.3.3 "Time Values"

Some libraries (Notably OneLogin php-saml) will reject responses with timestamps that are not UTC.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 41

Totals Coverage Status
Change from base Build 40: 0.0%
Covered Lines: 1121
Relevant Lines: 1618
💛 - Coveralls
amdonov commented 5 years ago

Looks good. Thanks! I will get this merged in a couple of days.

On Sun, Aug 4, 2019 at 7:18 AM Colin Campbell notifications@github.com wrote:

Standard here: http://docs.oasis-open.org/security/saml/v2.0/saml-core-2.0-os.pdf #1 https://github.com/amdonov/lite-idp/pull/1.3.3 "Time Values"

Some libraries (Notably OneLogin php-saml) will reject responses with timestamps that are not UTC.

You can view, comment on, or merge this pull request online at:

https://github.com/amdonov/lite-idp/pull/15 Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/amdonov/lite-idp/pull/15?email_source=notifications&email_token=AAFOCFDLRTTTZ7O43AUSOQTQC23G7A5CNFSM4IJFBCUKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HDHOPFQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFOCFAOLW5CZB2BMD3N2NDQC23G7ANCNFSM4IJFBCUA .