amdonov / lite-idp

Lightweight SAML Identity Provider
Apache License 2.0
210 stars 48 forks source link

Transpose retrieval of now time to get a more accurate time #26

Closed asprouse5 closed 4 years ago

asprouse5 commented 4 years ago

Moved the retrieval of the "now" time to later to get a more accurate time. When the line is earlier, the times can be just barely off. Example (Now is .000003 seconds before NotBefore):

NotBefore: 2020-06-01 17:50:52.703655 +0000 UTC Now: 2020-06-01 17:50:52.703652 +0000 UTC NotOnOrAfter: 2020-06-01 17:55:52.703655 +0000 UTC

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 67


Files with Coverage Reduction New Missed Lines %
idp/artifact.go 2 71.72%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 66: -0.1%
Covered Lines: 1158
Relevant Lines: 1639

💛 - Coveralls