amecava / adrenalina

Software Engineering
1 stars 1 forks source link

good code. #3

Closed ingconti closed 5 years ago

ingconti commented 5 years ago

here:

ing-sw-2019-Bertolini-Cavallo-Capaccio/src/main/java/it/polimi/ingsw/model/cards/WeaponCard.java

nice ideas

did You fully test them?

amecava commented 5 years ago

No we didn't fully test our weapon implementation, we're still working on the card effects tests and effect properties tests!

We're going from the bottom to the top to be sure that everything that a class uses works correctly before testing the outer class.

ingconti commented 5 years ago

it' s the correct approach

I hope You have learnt tests are VITAL to write robust classes