ameer1234567890 / OnlineNandroid

Nandroid Backup without Reboot
Other
117 stars 46 forks source link

Partition patch filenames are not always the same than those determined by CyanogenMod #10

Closed pommedeterresautee closed 11 years ago

pommedeterresautee commented 11 years ago

Hi,

I just noticed that for some devices, the partition patch filename is not the same than the one determined by the CyanogenMod team.

By example, Samsung Galaxy S is called galaxys by CyanogenMod and not i9000 (http://get.cm/).

I also noticed that the name used by CyanogenMod are re used by other application like Rom Manager by example and many build.prop files in custom Rom.

I think it would be better for compatibility reason and for ease to manage patch filename in third party programs to rename the file according to the one used as standards in the "Rom Industry" (if there is one :-).

I can provide a list of all known devices (technical name + commercial name) if you want it.

FYI, for some devices, mtd suffix has been added to the ROM name as the ROM uses mtd partition system. This has not, in my opinion, to be integrated in the patch filename as it is not about the device itself.

Regards

ameer1234567890 commented 11 years ago

I have rectified most of the device codenames whichever I know about. Regarding the mtd suffix, you are correct. For instance, galaxys does have non-mtd partition layout as well. So I use i9000 for the name. I see that CyanogenMod does not have a non-mtd layout, so no problem here?

pommedeterresautee commented 11 years ago

I sent you an email with every details!