search

ameer1234567890 / OnlineNandroid

Nandroid Backup without Reboot
Other
117 stars 46 forks source link

file listing takes like forever in case of TWRP backup #34

Closed materemias closed 10 years ago

materemias commented 10 years ago

the ...\tmp\list0 file building takes extremely long to finish in case of TWRP backup, with CM mode the whole backup is done in a few minutes. after the file list is ready the data partition is backed up quickly.

materemias commented 10 years ago

I did a quick measure, it can list like 10 files/sec on a nexus 5. this makes backing up data partition extremely slow.

ameer1234567890 commented 10 years ago

Can you try installing another busybox from Play Store and see if it gets any faster? Does this happen on any other device?

materemias commented 10 years ago

I did try it with other bb version too, analysing the script it seems that one of the file listing command takes much time to execute, resulting in slow file list building. No other device I could test know but on xda a different user also reported this. On 16 Feb 2014 08:00, "Ameer Dawood" notifications@github.com wrote:

Can you try installing another busybox from Play Store and see if it gets any faster? Does this happen on any other device?

Reply to this email directly or view it on GitHubhttps://github.com/ameer1234567890/OnlineNandroid/issues/34#issuecomment-35178899 .

ameer1234567890 commented 10 years ago

OK, I found the bug. I shall fix it in the next version.

materemias commented 10 years ago

great! thanks

On Tue, Feb 25, 2014 at 4:43 PM, Ameer Dawood notifications@github.comwrote:

OK, I found the bug. I shall fix it in the next version.

Reply to this email directly or view it on GitHubhttps://github.com/ameer1234567890/OnlineNandroid/issues/34#issuecomment-36020935 .

materemias commented 10 years ago

when do you plan to release the next version?

ameer1234567890 commented 10 years ago

Fixed in v9.50

hirenshah commented 10 years ago

ameer1234567890 this is the issue I have been emailing you about... it isn't fixed :(

hirenshah commented 10 years ago

I was looking through the code and decided to edit this part to stop it making the file lists:

            if $bb [ `$bb echo "$part_size" | $bb egrep "^[0-9]+$"` ]; then
                full_size=$part_size
            else
                full_size=$part_size
            fi
            maxfilesize=5120
            splitfilesize=1024
            if $bb [ $full_size -gt $maxfilesize ]; then