ameerkat / imdb-to-sql

Converts the plain text IMDB files available for download into a usable relational database format
Apache License 2.0
104 stars 38 forks source link

Disabled quote keys (postgres 9.3.4 compatible) #3

Closed madejejej closed 10 years ago

madejejej commented 10 years ago

Thanks for the awesome code!

There's one issue with postgres though - when you quote your keys it's not recognised as a valid query: imdb_data=# insert into actors (lname, fname, idactors) values ("a", "b", 3); ERROR: syntax error at or near "" LINE 1: insert into actors (lname,fname,idactors`) values ("a... ^ I'm not sure if postgres ever supported that (http://www.postgresql.org/docs/7.1/static/sql-insert.html doesn't mention the backquotes anywhere). Any other RDBMS I know doesn't need those as well.

I think it's safe to just not include the quote keys by default.

ameerkat commented 10 years ago

Thanks s1mplex!