search

ameerthehacker / node-calculator

A simple app for automated tests using jest
MIT License
1 stars 18 forks source link

Update app.js #40

Closed TingHongTeoh closed 4 years ago

TingHongTeoh commented 4 years ago

1.The code was "5! is 0" which is wrong because 5! should be 120. The reason answer 5! was 0 because calc.fact(-5) was used in the master code. Hence, I've changed to calc.fact(5) to obtain the answer 120.

  1. I've also added unit "inches" and changed sd to Standard Deviation so it is more clear.

3.I would also like to report an issue for factorial testing as factorial can use negative integers.

ameerthehacker commented 4 years ago

Thanks @TingHongTeoh for the contribution