search

ameingast / postgresql-simple-migration

PostgreSQL Schema Migrations for Haskell
Other
85 stars 48 forks source link

Raise upper bounds on base64-bytestring dependency #37

Open magthe opened 3 years ago

magthe commented 3 years ago

It looks like this change is OK:

From 079c5300001a0c3b16855b4d84f510eba0e7cc4e Mon Sep 17 00:00:00 2001
From: Magnus Therning <magnus@therning.org>
Date: Tue, 5 Jan 2021 16:29:21 +0100
Subject: [PATCH] Allow newer base64-bytestring versions

---
 postgresql-simple-migration.cabal | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/postgresql-simple-migration.cabal b/postgresql-simple-migration.cabal
index f56dafc..49c0a4e 100644
--- a/postgresql-simple-migration.cabal
+++ b/postgresql-simple-migration.cabal
@@ -38,7 +38,7 @@ Library
     default-extensions:     OverloadedStrings, CPP, LambdaCase
     default-language:       Haskell2010
     build-depends:          base                        >= 4.6      && < 5.0,
-                            base64-bytestring           >= 1.0      && < 1.1,
+                            base64-bytestring           >= 1.0      && < 1.2,
                             bytestring                  >= 0.10     && < 0.11,
                             cryptohash                  >= 0.11     && < 0.12,
                             directory                   >= 1.2      && < 1.4,
@@ -52,7 +52,7 @@ Executable migrate
     default-extensions:     OverloadedStrings, CPP, LambdaCase
     default-language:       Haskell2010
     build-depends:          base                        >= 4.6      && < 5.0,
-                            base64-bytestring           >= 1.0      && < 1.1,
+                            base64-bytestring           >= 1.0      && < 1.2,
                             bytestring                  >= 0.10     && < 0.11,
                             cryptohash                  >= 0.11     && < 0.12,
                             directory                   >= 1.2      && < 1.4,
-- 
2.30.0

I believe it could also be done via Hackage directly and thus not requiring a new release.

magthe commented 3 years ago

It would probably work to raise it so it includes the very latest version of base64-bytestring as well, but I haven't tested that myself.

maksbotan commented 3 years ago

Hi, any chances of fixing this? It would suffice to make a Hackage revision for that.

endgame commented 3 years ago

I have built this package using base64-bytestring-1.2.0.1. As a Hackage Trustee, I have published a new revision with base64-bytestring >= 1.0 && < 1.3.

Related PR: #39