Project Feedback

[amelafili]

Build a fansite for books, movies, video games, or anything else

@KatieMFritz Can you take a look at this? It's hosted here and meets the following criteria:

• [x] None of the routes on the website end with .html
• [x] A homepage exists, where the purpose of the site is explained
• [x] A "list page" exists that lists your top 3 favorite of this thing (e.g. /pokemon) -- each list item should link to the corresponding page for that favorite, detailed below
• [x] For each of your favorites, a page exists to display more information about it (e.g. /pokemon/bulbasaur) -- we want to make sure you practice multiple levels of nested routes
• [x] Every page includes links to the homepage and list page (although pages do not have to link to themselves)

[KatieMFritz]

Hi Amela, I haven't checked your code yet, but your hosted site is giving me a 404. Try some troubleshooting, and let me or Erik know if you can't get it working. 🚀

[amelafili]

I'm having some issues getting the website to go live :(

[KatieMFritz]

Can you tell me more about what you've tried and what's happening?

[amelafili]

I've already installed Surge and tried to push my files to Surge, but yet it still wont show anything on my live website.

[KatieMFritz]

Hm, okay. 🤔 What does your terminal say after your run the command to push to surge? Could you share a screenshot?

[amelafili]

[KatieMFritz]

Thanks, the screenshot is very helpful! When I looked at your code too, I realized that the Surge site is working - there just isn't an index.html file at the root of the site, so there is no home page. Try going to https://amelafili-html-multiple-pages.surge.sh/about/ - there's your beautiful site! 🐢 🌊

Try restructuring your site so there is a homepage (index.html in the root/main folder of the repository). Once you get that working (and check the other requirements - I'll post below for reference), let me know and I'll review the rest! 🚀

Reminder of what to do before resubmitting:

1. Review the project requirements, making sure you understand and have met each of them (ask if you're not sure).
2. Review the comments from me or Erik and resolve each one of them.
3. Get rid of any unused files and code in your repository.
4. Check your project in the W3 validator and resolve errors and warnings.
5. Look over your hosted site and make sure it looks professional and works the way you expect.
6. Make sure your latest changes show up on all branches you are using.

[amelafili]

I've managed to make the website live!

[egillespie]

Hi @amelafili, would some of your pages do not pass W3 validation and contain invalid HTML.

More on W3 validation

Would you mind addressing all of the issues pointed out by the W3 validator for each of your routes? We'll continue to uphold the code quality standards introduced in previous lessons even though they're not explicitly stated. Just like a real job, we want to make sure your code is always of the highest quality possible before we ship it to production! 😄

Homepage links

It looks like you should also add a link to the homepage to each of your routes as well, as indicated by the requirement "Every page includes links to the homepage and list page (although pages do not have to link to themselves)".

---

I think your pages in this project look great and I'm excited to see your code look just as beautiful as those majestic turtles. :)

After you’ve made your changes and pushed them to GitHub and your hosted site, give it a once-over to make sure it looks right, then comment back here and I’ll take another look.

Thanks! 🐢

[amelafili]

I've fixed these issues! Thank you!

[egillespie]

Hi @amelafili, thanks for making the latest round of changes. Your website is really shaping up and looking amazing! 😄

I see two other things to clear up, then we'll be on our way to bigger and brighter projects!

1. Use nested routes

For each of your favorites, a page exists to display more information about it (e.g. /pokemon/bulbasaur) -- we want to make sure you practice multiple levels of nested routes

Would you mind demonstrating nested routes in your project by moving the boxturtle, seaturtle, and snappingturtle directories inside of your list directory? Remember to update the links in /list/index.html and make sure they work on your hosted site!

2. Remove about directory

Since you're no longer using the about directory, could you please remove it? It helps avoid confusion for future developers — even yourself — when you remove unused or unreachable code. It also reduces the project size, which can sometimes make uploads and downloads go faster.

---

After you’ve made your changes and pushed them to GitHub and your hosted site, give it a once-over to make sure it looks right, then comment back here and I’ll take another look.

Thanks! 🌈🌟

[amelafili]

I've fixed these issues! Thank you for your help.

[egillespie]

Hi @amelafili, I see your changes on Surge, but I don't see them in GitHub. Did you perhaps forget to commit and push them?

[amelafili]

It should be there now! Thanks!

[egillespie]

I'm still not seeing the changes in your master branch on GitHub (this page). I see you have a gh-pages branch, so you may have committed and pushed to the wrong branch.

There should be step-by-step instructions to push your changes to the master branch on the Project tab for this lesson. Follow those and make sure the about directory no longer appears in my first link, then comment here and I'll take another look.

[amelafili]

i think i've updated this now, sorry for the mix up!

[egillespie]

I can see the code now, and it's just what I was looking for! I'm excited to see this all come together so well. Keep it up! 🐢 :shipit: