ameliabradley / wikiedit-monitor

Wikipedia monitor
3 stars 2 forks source link

Added scripts to set up a Docker container w/ wikiedit-monitor running. #33

Closed Barbarrosa closed 8 years ago

Barbarrosa commented 8 years ago

@leebradley This switches to the library mentioned in https://github.com/leebradley/wikiedit-monitor/issues/20 and adds scripts for creating a development Docker container.

ameliabradley commented 8 years ago

Looks good, just a few notes: 1) Streamline instructions to just the docker instruction set 2) As we discussed, we need to add run-script to the npm command

ameliabradley commented 8 years ago

Maybe instead of updating the npm scripts and whatnot, we should consider including a docker-compose.yml file?

See: https://docs.docker.com/compose/gettingstarted/

Barbarrosa commented 8 years ago

@leebradley I implemented your suggestion to use Docker Compose, and I tested to make sure that it works.

ameliabradley commented 8 years ago

Awesome 👍