amelioro / ameliorate

A tool for analyzing debatable problems effectively, collaboratively, and with an open mind.
https://ameliorate.app
MIT License
26 stars 10 forks source link

fix: changes lost on navigate back #538

Closed keyserj closed 1 month ago

keyserj commented 1 month ago

to reproduce:

  1. create or open a topic you can edit
  2. make some edits (add/remove nodes)
  3. go to settings page
  4. use back button to go back to your topic
  5. observe your edits have been undone

this happened because the API request to load data for a topic was being kept fresh forever, so it would never re-request without a page refresh. once loaded with old data, the old data was saved, because all state changes are saved.

in this case, navigating using the back button would perform an SPA page navigation, reusing the data it was previously loaded with.

this bug was introduced by #441

Description of changes

-

Additional context

-

netlify[bot] commented 1 month ago

Deploy Preview for ameliorate-docs canceled.

Name Link
Latest commit e389fa1ff84f55f9b7887b3c056c3b6ef36d26c3
Latest deploy log https://app.netlify.com/sites/ameliorate-docs/deploys/6715806ed8ea6a00080f8414
netlify[bot] commented 1 month ago

Deploy Preview for velvety-vacherin-4193fb ready!

Name Link
Latest commit e389fa1ff84f55f9b7887b3c056c3b6ef36d26c3
Latest deploy log https://app.netlify.com/sites/velvety-vacherin-4193fb/deploys/6715806ef024250008e8de7e
Deploy Preview https://deploy-preview-538--velvety-vacherin-4193fb.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 60
Accessibility: 86
Best Practices: 92
SEO: 85
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

keyserj commented 1 month ago

FYI @prototyperspective this fixes the issue you ran into with losing your data

prototyperspective commented 1 month ago

Yes, great to see such a quick fix!