search

ameltech / sme-arduino-core

Arduino core for Smart Everything board
GNU General Public License v2.0
3 stars 13 forks source link

New function to flash the RGB LED light for X milliseconds #12

Closed unbiot closed 8 years ago

smkkHw commented 8 years ago

Good idea.

Considering the other helper function to drive the RGB led could be possible be more similar in term of function name ?

some example 1) create 3 different API "flashLed" 1) remain in one function but with a more explicit name that is for RGB "flashRGBLed"

unbiot commented 8 years ago

Thanks for the feedback! I renamed the function per your suggestion.

I prefer having one function rather than three. I think it makes more sense for beginners since it's controlling the same physical LED. Please merge if this looks ok to you.