search

amendlik / salt-gen-resource

Generate Rundeck node resources from the Salt Mine
Other
8 stars 7 forks source link

Fix error message from Salt 2017.7 #1

Closed some-natalie closed 7 years ago

some-natalie commented 7 years ago

After upgrading to Salt 2017.7, this script returns an error message from Salt about using "tgt_type" over "expr_form". Changing this appears to break nothing and the script works as expected.

amendlik commented 7 years ago

@natalie- Thank you for the PR. Just so I know that we're looking at the same thing, are you getting an error that causes the script to fail, or just a deprecation warning about using expr_form?

some-natalie commented 7 years ago

@amendlik It's just clearing up a deprecation warning we found after upgrading to SaltStack 2017.7. Rundeck didn't appear to have any problems with it, but we use the script elsewhere as well to generate a nice YAML inventory.

amendlik commented 7 years ago

@natalie- I added some changes to make this change backwards-compatible with 2016.11 and earlier. Could you test this version and let me know the results?

some-natalie commented 7 years ago

@amendlik Works great! I tested it on some machines running 2017.7 and 2016.11 and it worked fine on both. 👍