amenezes / config-client

config-client package for spring cloud config and cloud foundry
https://config-client.amenezes.net/
Apache License 2.0
24 stars 18 forks source link

question - using with SCS 3 #24

Closed nealplotnikgit closed 4 years ago

nealplotnikgit commented 4 years ago

was testing out this library in our Pivotal CF instance. provisioned service like cf create-service -c { "git": { "uri": "https://github.com/spring-cloud-samples/config-repo" }, "count": 1 } p.config-server standard config-server

and then i bind it to the simpleweb000 service provisions & binds ok but the simpleweb000 app example crashes. I am suspecting this is because it's looking for p-config-server which is an SCS 2.X but in SCS 3 it is now p.config-server was wondering if config-client is then compatible with SCS 3.x?

2020-03-06T13:46:27.855-06:00 [APP/PROC/WEB/0] [ERR] self.cfenv = attr_factory_cfenv() 2020-03-06T13:46:27.855-06:00 [APP/PROC/WEB/0] [ERR] File "<attrs generated init 937803616bd1ea7913d956dac2aec481ca1035b7>", line 9, in init 2020-03-06T13:46:27.855-06:00 [APP/PROC/WEB/0] [ERR] self.attrs_post_init() 2020-03-06T13:46:27.855-06:00 [APP/PROC/WEB/0] [ERR] File "/home/vcap/deps/0/python/lib/python3.6/site-packages/config/cfenv.py", line 33, in attrs_post_init__ 2020-03-06T13:46:27.855-06:00 [APP/PROC/WEB/0] [ERR] "p-config-server" 2020-03-06T13:46:27.855-06:00 [APP/PROC/WEB/0] [ERR] KeyError: 'p-config-server' 2020-03-06T13:46:27.855-06:00 [APP/PROC/WEB/0] [ERR] [2020-03-06 19:46:27 +0000] [109] [ERROR] Exception in worker process 2020-03-06T13:46:27.855-06:00 [APP/PROC/WEB/0] [ERR] [2020-03-06 19:46:27 +0000] [110] [ERROR] Exception in worker process

thanks - if there is another place to ask the question besides here please let me know. thank you for your efforts on this library

amenezes commented 4 years ago

Hello @nealplotnikgit,

Did you bind the application with the service? For example, running: cf bind-service simpleweb000 config-server

Observe too that the name of your application will be used to retrieve configuration from config-server. For use of simpleweb000 I suggest to you point your config-server to:

{ "git": { "uri": "https://github.com/amenezes/spring_config" }

But if you prefer use the link shared make sure that your application corresponds with some file.

In the link below you can get more information about how the settings request URL will be formed

amenezes commented 4 years ago

@nealplotnikgit,

I will close this issue for now, but if you yet has some doubt or problem let me know.