search

amenezes / config-client

config-client package for spring cloud config and cloud foundry
https://config-client.amenezes.net/
Apache License 2.0
24 stars 18 forks source link

Pass non init args to request #33

Closed luiscoms closed 4 years ago

luiscoms commented 4 years ago

This pull request improves config_client decorator passing args to get_config method.

# app_name is a class init param
@config_client(app_name='awesome-app')  
def foo(client):
   return client

# timeout isn't a class init param, so this will be passed to get_config
@config_client(timeout=5)
def foo(client):
   return client
luiscoms commented 4 years ago

Hi @amenezes did you have any consideration?

amenezes commented 4 years ago

Good job @luiscoms :clap:

I'm working in a improvement to release on the version 0.10.0 and probably I'will merge this PR with this release. I notify you when the work done.

Thanks.

A single observation try fix the conflict being reported, please.

luiscoms commented 4 years ago

Hi @amenezes the tests are passing but there is an error on ci

amenezes commented 4 years ago

@luiscoms,

Looks like there's been a change in Travis CI. See the message:

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions

Don't worry. When I merge I make the correction.

luiscoms commented 4 years ago

Hi @amenezes , when you intend to do this merge?

luiscoms commented 4 years ago

Hi @amenezes , some updates?