search

amenezes / config-client

config-client package for spring cloud config and cloud foundry
https://config-client.amenezes.net/
Apache License 2.0
24 stars 17 forks source link

Add request retry #34

Closed luiscoms closed 4 years ago

luiscoms commented 4 years ago

Add request retry in order to prevent eventual server error

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging db4daf955135e86b476d65b33cddd02e46db9a68 into 761f39cd8839daba10bf21b98ccdd44d33eaebe8 - view on LGTM.com

new alerts:

luiscoms commented 4 years ago

Hi @amenezes some considerations about this?

amenezes commented 4 years ago

@luiscoms,

I prefer guide the use of this feature through a external library, maybe something like described in the Config Client Retry documentation. There are many options to use this feature in the PyPI.

The author of this article chose an approach similar to yours including the implementation. Look that although for the author other related approaches are not the best, I think that for simpler use cases they can work and for others that have more specific needs the external libraries have better support.

Maybe, still watching the issues and considerations related to pattern retry I think that a approach less opinionated can cover more use cases and still be more flexible.

What do you think about?